refactor(fullstack): clear sonarcloud code smells and cpd false positive - #368
Merged
Conversation
- extract nested ternaries into branches (S3358): mobile dashboard and map, simulate_zone - reduce cognitive complexity in geo, timescale and worker modules (S3776) - dedupe 'Zone not found' literal into a constant (S1192) - name the anonymous namespaces in the gnss firmware module (S1000) - use Array.at and toSorted in the mobile seismograph window (S7755, S4043) - exclude the structurally identical map theme palettes from duplication (cpd)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the 13 SonarCloud code smells and the 0.8% duplicated lines reported on main after the v1.2.1 release.
Code smells cleared (13 -> 0)
ZONE_NOT_FOUNDconstantquakeguard_gnssArray.at(-1)toSorted()Duplication (0.8% -> 0)
mobile/theme/mapStyle.tsexcluded from CPD analysis:lightMapStyle/darkMapStyleshare the same featureType/elementType keys but are two independent palettes — a known structural false positive.Verification
tsc --noEmit: cleanChanges will land in the v1.2.2 release.