site: use unique page descriptions - #501
Open
Tiancheng-Xu wants to merge 2 commits into
Open
Conversation
Collaborator
|
I don't think we need the test file, just the descriptions. |
Author
|
Addressed the review: removed the added description-check script and package test hook, keeping the PR focused on the four page descriptions only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #366. The API, Approach, Demo, and Measure pages now provide page-specific meta descriptions through their existing front matter metadata path. Added a build-output regression check to prevent those pages from reusing the same generic description. Tests: site npm test (stylelint, production Eleventy build, description check); root npm test (build-all, uvu 19 passed, 1 skipped); npm run lint; npm run size (all limits passed); git diff --check.