feat(skills): introduce cluster toolkit agent skills, evals and gke-kueue debugging skill - #6258
feat(skills): introduce cluster toolkit agent skills, evals and gke-kueue debugging skill#6258shubpal07 wants to merge 2 commits into
Conversation
…g skill - Add skills/ with contributor guide and gke-kueue debugging skill - Add tools/run_eval.py deterministic evaluation engine and 49 unit tests - Add skills-lint GitHub Actions workflow, pre-commit hook, and make targets Change-Id: Ia049aa7d35622a8565f65efeda7cdc0de260c831
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request establishes a robust framework for integrating AI-driven diagnostic and operational skills into the Cluster Toolkit. By providing a standardized specification for skill authoring, a deterministic evaluation engine, and automated CI/CD pipelines, it enables developers to create safe, domain-specific diagnostic workflows for complex HPC and AI/ML infrastructure, starting with a comprehensive reference implementation for GKE Kueue debugging. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new agent skills framework for the Cluster Toolkit, including a comprehensive GKE Kueue debugging playbook, reference documentation, and an offline evaluation runner (tools/run_eval.py) with associated unit tests. The review feedback highlights critical improvements: addressing a potential safety bypass in the evaluation runner's response scanning logic, correcting an unsupported field selector on Kueue Workload CRDs, and fixing a logical AND label selector bug that would prevent GKE accelerator nodes from being listed correctly.
| limitations under the License. | ||
| --> | ||
|
|
||
| # GKE Kueue Cohorts & Accelerator Infrastructure Reference |
There was a problem hiding this comment.
nit: to avoid same skill name from other sources, consider prefixing the skills with ct or gct.
… security Change-Id: I17a5965fdd70041570fcc94dd98d5caa07c222b9
Overview
This PR introduces the Agent Skills Framework to Cluster Toolkit along with the
gke-kueue-debuggingreference skill and offline evaluation infrastructure.The framework is aligned with the open agentskills.io specification, enabling AI coding agents (such as Gemini Code Assist, Antigravity, Claude Code, Cursor, Windsurf, GitHub Copilot, etc) to provide domain-specific diagnostic and operational assistance for Google Cloud HPC and AI/ML infrastructure without requiring external API keys, runtime tokens, or cloud permissions during presubmit.
Key Deliverables
1. Specification & Authoring Guide (
skills/)skills/README.md: Complete contributor specification covering the 3-tier progressive disclosure model (Metadata -> Stepwise Instructions -> On-demand References), frontmatter schema rules, safety protocols (read-only command isolation, confirmation gating), and evaluation authoring guide.skills/gke-kueue-debugging/: Reference skill providing structured, non-destructive diagnostic workflows for GKE Kueue batch admission, cohort borrowing, ResourceFlavor taints/labels, Head-of-Line (HOL) blocking, and GKE DWS Flex-start integration.skills/gke-kueue-debugging/references/: Tier 3 progressive disclosure technical documentation detailing official Kueue APIs (kueue-docs.md) and GKE Cohort quota architectures (gke-kueue-docs.md).2. Evaluation & Linting Engine (
tools/run_eval.py)expect_keywords_all,expect_keywords_any,expect_blocked_action) and regex-bounded safety constraints (forbidden_commands).kubectl delete,helm uninstall,terraform destroy) is blocked unless explicitly gated inside a[PROPOSED REMEDIATION PLAN]requiring human operator confirmation.3. Comprehensive Unit Test Suite (
tools/tests/test_run_eval.py)4. CI/CD Automation & Developer Ergonomics
.github/workflows/skills-lint.yml): Automated presubmit CI workflow running static linting, offline mock evals, and unit tests on PRs modifying skills or evaluation tools..pre-commit-config.yaml): Added localskills-lintpre-commit hook and excluded frontmatter markdown from PyMarkdown MD041.Makefile): Addedmake lint-skillsandmake test-skillsshortcuts matching repository developer conventions.Verification & Test Results
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.