fix : remove computed bucket name from count in gke-persistent-volume

[agrawalkhushi18]

This pull request simplifies the conditional logic in modules/file-system/gke-persistent-volume/main.tf by removing the var.gcs_bucket_name != null check from the count attribute of both the google_project.cluster_project data source and the google_storage_bucket_iam_member.gke_service_agent resource.

Removing var.gcs_bucket_name != null from the count condition resolves the plan-time failure (Error: Invalid count argument). When buckets are declared dynamically (e.g. using random_suffix = true), the bucket name is an unknown value during terraform plan, making unknown != null indeterminate at plan time. By scoping count strictly to plan-known flags (local.has_gcsfuse_storage_profile and var.grant_gcsfuse_service_agent_role), count is deterministic, while Terraform safely defers bucket = var.gcs_bucket_name resolution to apply time.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

• Fork your PR branch from the Toolkit "develop" branch (not main)
• Test all changes with pre-commit in a local branch #
• Confirm that "make tests" passes all tests
• Add or modify unit tests to cover code changes
• Ensure that unit test coverage remains above 80%
• Update all applicable documentation
• Follow Cluster Toolkit Contribution guidelines #

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request simplifies the resource creation logic for GKE persistent volume service agent roles. By removing the requirement that the GCS bucket name must be provided to trigger the IAM member creation, the module becomes more flexible in scenarios where bucket information might be handled differently or is not explicitly required for the role assignment.

Highlights

• IAM Configuration Logic: Updated the conditional logic for GKE service agent IAM roles to remove the dependency on the GCS bucket name being non-null.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request simplifies the conditional logic in modules/file-system/gke-persistent-volume/main.tf by removing the var.gcs_bucket_name != null check from the count attribute of both the google_project.cluster_project data source and the google_storage_bucket_iam_member.gke_service_agent resource. There are no review comments to address, and I have no additional feedback to provide.

[agrawalkhushi18]

SUCCESS:
PR-test-gke-h4d-onspot
PR-test-gke-a4-onspot (hpc-toolkit-dev)
PR-test-gke-a3-ultragpu-onspot (hpc-toolkit-dev)

FAIL:
R-test-gke-managed-lustre (hpc-toolkit-dev) - Passed the terraform plan stage, failed due to capacity constraints.
PR-test-gke-storage (hpc-toolkit-dev)- Passed the terraform plan stage, failed due to capacity constraints.