Update gib version to 1.1.3 across gke and slurm blueprints - #6263
Update gib version to 1.1.3 across gke and slurm blueprints#6263wendiliao wants to merge 1 commit into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the NCCL gIB plugin version to v1.1.3 across various GKE and Slurm blueprints. The changes ensure that all deployment configurations, diagnostic containers, and build environments are aligned with the latest release, while also updating the supported version lists in the Terraform management modules. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the NCCL GIB plugin version from v1.1.2 to v1.1.3 across multiple GKE blueprints, machine learning examples, and Terraform variables. Feedback is provided regarding a discrepancy where the PR description mentions updates to the A3 Ultra custom image blueprint (such as nccl_gib_version and libnccl_version), but the corresponding files appear to be missing from the commit.
| gib_supported_versions_x86 = ["v1.1.3", "v1.1.2", "v1.1.0", "v1.0.6", "v1.0.5", "v1.0.3", "v1.0.2"] | ||
| gib_supported_versions_arm64 = ["v1.1.3", "v1.1.2", "v1.1.0", "v1.0.7"] |
There was a problem hiding this comment.
The PR description mentions updating nccl_gib_version and libnccl_version (to 2.31.2-1+cuda13.0) in the A3 Ultra custom image blueprint, but those changes and files (such as Slurm custom image blueprints or Packer templates) are not included in this pull request. Please verify if those files were accidentally omitted from the commit.
|
/gcbrun |
|
Hi @wendiliao , Can you please address the gemini review comment above. Please update the PR description accordingly. |
Description
Updates the NCCL gIB version in the A3 Ultra custom image blueprint to the
1.1.3release.Changes:
nccl_gib_version: Updated to1.1.3libnccl_version: Updated to2.31.2-1+cuda13.0