Create Client side metrics for redis#10271
Open
fosky94 wants to merge 3 commits into
Open
Conversation
product-auto-label
Bot
added
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new Java application, RedisTelemetryApp, demonstrating the integration of Redis with OpenTelemetry for tracing and metrics. Key feedback includes the need to fix the pom.xml file, which is currently invalid due to a missing root element and parent configuration. Additionally, the OpenTelemetry implementation requires updates to ensure spans are made current for proper trace nesting, and the application blocking latency metric should be adjusted to reflect meaningful business logic processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new sample code to log client side metrics and traces for redis. this will be added to the public docs once this sample code is posted
client libraries that need to be installed (added to pom.xml file):
redis.clients jedis 5.1.0 io.opentelemetry opentelemetry-api 1.36.0 io.opentelemetry opentelemetry-sdk 1.36.0 com.google.cloud.opentelemetry exporter-trace 0.28.0-alpha com.google.cloud.opentelemetry exporter-metrics 0.28.0-alpha