Skip to content

secretmanager: add list resource for google_secret_manager_secret_version - #18485

Closed
vr-ibm wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
vr-ibm:feat/secret-manager-secret-version-list-resource
Closed

secretmanager: add list resource for google_secret_manager_secret_version#18485
vr-ibm wants to merge 4 commits into
GoogleCloudPlatform:mainfrom
vr-ibm:feat/secret-manager-secret-version-list-resource

Conversation

@vr-ibm

@vr-ibm vr-ibm commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Adds a new list resource google_secret_manager_secret_version for Terraform 1.14+ terraform query support. This allows users to list all Secret Manager secret versions for a given secret.

Details

  • Adds list resource implementation for google_secret_manager_secret_version
  • Adds acceptance test TestAccSecretManagerSecretVersionListResource_queryIdentity
  • Adds documentation for the list resource

Release Note Template for Downstream PRs (will be copied)

secretmanager: added `google_secret_manager_secret_version` list resource for `terraform query` support

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/secretmanager and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 31, 2026
@modular-magician

modular-magician commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 55c5aad:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 188 insertions(+), 8 deletions(-)
google-beta provider View Diff 6 files changed, 481 insertions(+), 8 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
48 36 5 7
Affected Service Packages
  • secretmanager

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccSecretManagerSecretVersionListResource_basic
  • TestAccSecretManagerSecretVersion_secretVersionBasicExample
  • TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample
  • TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyAbandonExample
  • TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyDisableExample
  • TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataExample
  • TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccSecretManagerSecretVersion_secretVersionBasicExample
✅ Log TestAccSecretManagerSecretVersion_secretVersionBasicWriteOnlyExample
✅ Log TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyAbandonExample
✅ Log TestAccSecretManagerSecretVersion_secretVersionDeletionPolicyDisableExample
✅ Log TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataExample
✅ Log TestAccSecretManagerSecretVersion_secretVersionWithBase64StringSecretDataWriteOnlyExample
❌ Error · Log - TestAccSecretManagerSecretVersionListResource_basic

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@vr-ibm VCR tests complete for 55c5aad!

@BBBmau
BBBmau force-pushed the feat/secret-manager-secret-version-list-resource branch from 55c5aad to e25d54a Compare September 8, 2026 18:43
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 8, 2026
@modular-magician

modular-magician commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e25d54a:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 68 insertions(+)
google-beta provider View Diff 3 files changed, 361 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
49 43 5 1
Affected Service Packages
  • secretmanager

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccSecretManagerSecretVersionListResource_basic

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccSecretManagerSecretVersionListResource_basic

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@vr-ibm VCR tests complete for e25d54a!

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 8, 2026
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 8, 2026
@modular-magician

modular-magician commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4559660:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 361 insertions(+)
google-beta provider View Diff 3 files changed, 361 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
49 43 5 1
Affected Service Packages
  • secretmanager

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccSecretManagerSecretVersionListResource_basic

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccSecretManagerSecretVersionListResource_basic

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@vr-ibm VCR tests complete for 4559660!

@modular-magician

modular-magician commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1f21f4d:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 361 insertions(+)
google-beta provider View Diff 3 files changed, 361 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
49 43 5 1
Affected Service Packages
  • secretmanager

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccSecretManagerSecretVersionListResource_basic

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccSecretManagerSecretVersionListResource_basic

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@vr-ibm VCR tests complete for 1f21f4d!

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 8, 2026
@modular-magician

modular-magician commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7963ecb:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 368 insertions(+)
google-beta provider View Diff 3 files changed, 368 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
49 43 5 1
Affected Service Packages
  • secretmanager

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccSecretManagerSecretVersionListResource_basic

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccSecretManagerSecretVersionListResource_basic

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@vr-ibm VCR tests complete for 7963ecb!

@BBBmau

BBBmau commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Superseded by #18928, which contains the generic list-resource identity fix.

@BBBmau BBBmau closed this Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants