Skip to content

Refractor IAM list code to support upcoming iam binding list resources - #18708

Merged
malhotrasagar2212 merged 1 commit into
GoogleCloudPlatform:mainfrom
malhotrasagar2212:list_support_for_iam_binding
Sep 8, 2026
Merged

Refractor IAM list code to support upcoming iam binding list resources#18708
malhotrasagar2212 merged 1 commit into
GoogleCloudPlatform:mainfrom
malhotrasagar2212:list_support_for_iam_binding

Conversation

@malhotrasagar2212

@malhotrasagar2212 malhotrasagar2212 commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Release Note Template for Downstream PRs (will be copied)
Refractor IAM list code to add common file for all IAM list resources.
See Write release notes for guidance.

@modular-magician

modular-magician commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6f60aa8:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 481 insertions(+), 205 deletions(-)
google-beta provider View Diff 3 files changed, 481 insertions(+), 205 deletions(-)

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Test report

Analytics

Total Tests Passed Skipped Affected
0 0 0 0
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Caution

🔴 Errors occurred during REPLAYING mode. Please check the build log for details.

View the replaying VCR build log

@malhotrasagar2212 VCR tests complete for 6f60aa8!

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 686ece6:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 511 insertions(+), 206 deletions(-)
google-beta provider View Diff 4 files changed, 511 insertions(+), 206 deletions(-)
terraform-google-conversion View Diff 1 file changed, 24 insertions(+)

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

@modular-magician

modular-magician commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e82231e:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 653 insertions(+), 206 deletions(-)
google-beta provider View Diff 5 files changed, 653 insertions(+), 206 deletions(-)
terraform-google-conversion View Diff 1 file changed, 24 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
6948 6239 698 11
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccContainerCluster_autopilot_privileged_admission
  • TestAccContainerCluster_dataplaneOptimizationMode
  • TestAccContainerNodePool_withSoleTenantConfig
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
  • TestAccVertexAISemanticGovernancePolicyEngine_basic

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccContainerCluster_autopilot_privileged_admission
❌ Error · Log - TestAccContainerCluster_dataplaneOptimizationMode
❌ Error · Log - TestAccContainerNodePool_withSoleTenantConfig
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated
❌ Error · Log - TestAccVertexAISemanticGovernancePolicyEngine_basic

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@malhotrasagar2212 VCR tests complete for e82231e!

@malhotrasagar2212
malhotrasagar2212 marked this pull request as ready for review September 2, 2026 15:32
// IamMemberListResource lists IAM member rows by reading IAM policies on one or more policy targets.
// It embeds iamListCore for all shared behaviour and adds only member-specipic shaping below.
type IamMemberListResource struct {
tpgresource.ListResourceMetadata

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do this in a separate refactor PR to reduce the review scope of this

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept only the refactored code in this and created a separate PR that adds binding support.

@malhotrasagar2212
malhotrasagar2212 force-pushed the list_support_for_iam_binding branch from e82231e to bd0f72b Compare September 8, 2026 18:10
@malhotrasagar2212 malhotrasagar2212 changed the title List support for iam binding Refractor IAM list code to support upcoming iam binding list resources Sep 8, 2026
@malhotrasagar2212

Copy link
Copy Markdown
Collaborator Author

/gcbrun

@modular-magician

modular-magician commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit bd0f72b:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 2 files changed, 262 insertions(+), 205 deletions(-)
google-beta provider View Diff 2 files changed, 262 insertions(+), 205 deletions(-)

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Test report

Analytics

Total Tests Passed Skipped Affected
6982 6265 698 19
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccComputeBackendService_backendServiceInFlightExample
  • TestAccComputeInstanceFromMachineImage_diffProject
  • TestAccComputeInstanceTemplate_gracefulShutdown
  • TestAccComputeInstance_GracefulShutdownWithResetUpdate
  • TestAccComputeInstance_GracefulShutdownWithoutResetUpdate
  • TestAccComputeRegionInstanceTemplate_gracefulShutdown
  • TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
  • TestAccComputeTargetInstance_withSecurityPolicy
  • TestAccContainerCluster_autopilot_privileged_admission
  • TestAccContainerCluster_dataplaneOptimizationMode
  • TestAccContainerNodePool_withSoleTenantConfig
  • TestAccDataSourceGoogleComputeInterconnectLocation_basic
  • TestAccDataSourceGoogleStorageControlOrganizationIntelligenceFindingsSummary_empty
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccObservabilityLink_observabilityLinkBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample
  • TestAccTpuV2Vm_update
  • TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDataSourceGoogleComputeInterconnectLocation_basic
✅ Log ❌ Error · Log TestAccObservabilityLink_observabilityLinkBasicExample
❌ Error · Log - TestAccComputeBackendService_backendServiceInFlightExample
❌ Error · Log - TestAccComputeInstanceFromMachineImage_diffProject
❌ Error · Log - TestAccComputeInstanceTemplate_gracefulShutdown
❌ Error · Log - TestAccComputeInstance_GracefulShutdownWithResetUpdate
❌ Error · Log - TestAccComputeInstance_GracefulShutdownWithoutResetUpdate
❌ Error · Log - TestAccComputeRegionInstanceTemplate_gracefulShutdown
❌ Error · Log - TestAccComputeSecurityPolicy_withPreconfiguredWafConfig
❌ Error · Log - TestAccComputeTargetInstance_withSecurityPolicy
❌ Error · Log - TestAccContainerCluster_autopilot_privileged_admission
❌ Error · Log - TestAccContainerCluster_dataplaneOptimizationMode
❌ Error · Log - TestAccContainerNodePool_withSoleTenantConfig
❌ Error · Log - TestAccDataSourceGoogleStorageControlOrganizationIntelligenceFindingsSummary_empty
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample
❌ Error · Log - TestAccTpuV2Vm_update
❌ Error · Log - TestAccVertexAIFeatureOnlineStoreFeatureview_vertexAiFeatureonlinestoreFeatureview_featureRegistry_updated

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@malhotrasagar2212, @BBBmau VCR tests complete for bd0f72b!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants