Refractor IAM list code to support upcoming iam binding list resources - #18708
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6f60aa8: Diff reportYour PR generated the following diffs in downstream repositories:
Errors
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Caution 🔴 Errors occurred during REPLAYING mode. Please check the build log for details. View the replaying VCR build log @malhotrasagar2212 VCR tests complete for 6f60aa8! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 686ece6: Diff reportYour PR generated the following diffs in downstream repositories:
Errors
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e82231e: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @malhotrasagar2212 VCR tests complete for e82231e! |
| // IamMemberListResource lists IAM member rows by reading IAM policies on one or more policy targets. | ||
| // It embeds iamListCore for all shared behaviour and adds only member-specipic shaping below. | ||
| type IamMemberListResource struct { | ||
| tpgresource.ListResourceMetadata |
There was a problem hiding this comment.
let's do this in a separate refactor PR to reduce the review scope of this
There was a problem hiding this comment.
Kept only the refactored code in this and created a separate PR that adds binding support.
e82231e to
bd0f72b
Compare
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit bd0f72b: Diff reportYour PR generated the following diffs in downstream repositories:
Errors
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 19 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @malhotrasagar2212, @BBBmau VCR tests complete for bd0f72b! |
3a8aa13
Release Note Template for Downstream PRs (will be copied)
Refractor IAM list code to add common file for all IAM list resources.
See Write release notes for guidance.