mark plaintext credential fields as sensitive across resources - #18924
Open
naruto-lgtm wants to merge 1 commit into
Open
mark plaintext credential fields as sensitive across resources#18924naruto-lgtm wants to merge 1 commit into
naruto-lgtm wants to merge 1 commit into
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:
terraform planon any of the touched resources with a literal secret, for examplegoogle_identity_platform_oauth_idp_configwithclient_secret = "..."; the plan prints the literal, and so doterraform showand any CI log that captures the run.Cause: these fields carry plaintext credentials (passwords, OAuth client secrets, a Salesforce security token, bearer and JWT tokens, a PKCS12 passphrase, an encrypted private key) but the schema never marks them sensitive; the sibling Datastream profiles already flag their
password, so the Salesforce profile was simply missed, and the remaining fields have the same shape.Fix:
sensitive: trueon each field in the product YAML andSensitive: trueon the three handwritten schemas; with the patched provider the same plan renders(sensitive value)for every one of them, and apply and state behavior are unchanged.Release Note Template for Downstream PRs (will be copied)