Skip to content

agenticapplications: add methodology_export_options to persona - #18927

Open
slevenick wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-558523030
Open

agenticapplications: add methodology_export_options to persona#18927
slevenick wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-558523030

Conversation

@slevenick

Copy link
Copy Markdown
Contributor

Added field coverage for artifactsConfig.methodologyExportOptions (appendMethodology, exportFormat, exportMethodologyArtifact) on google_agentic_applications_analyst_agent_persona (agenticapplications:v1:AnalystAgentPersona).

reference: b/558523030

agenticapplications: added `artifacts_config.methodology_export_options` field to `google_agentic_applications_analyst_agent_persona`

@modular-magician

modular-magician commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3794da5:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 171 insertions(+), 218 deletions(-)
google-beta provider View Diff 4 files changed, 171 insertions(+), 218 deletions(-)
terraform-google-conversion View Diff 1 file changed, 55 insertions(+)
Open in Cloud Shell View Diff 2 files changed, 20 insertions(+), 142 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
2 1 0 1
Affected Service Packages
  • agenticapplications

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAgenticApplicationsAnalystAgentPersona_analystAgentPersonaFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccAgenticApplicationsAnalystAgentPersona_analystAgentPersonaFullExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for 3794da5!

@modular-magician

modular-magician commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit beefa18:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 268 insertions(+)
google-beta provider View Diff 4 files changed, 268 insertions(+)
terraform-google-conversion View Diff 1 file changed, 55 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 234 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
3 1 0 2
Affected Service Packages
  • agenticapplications

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAgenticApplicationsAnalystAgentPersona_analystAgentPersonaFullExample
  • TestAccAgenticApplicationsAnalystAgentPersona_analystAgentPersonaMethodologyExportOptionsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccAgenticApplicationsAnalystAgentPersona_analystAgentPersonaFullExample
✅ Log TestAccAgenticApplicationsAnalystAgentPersona_analystAgentPersonaMethodologyExportOptionsExample

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for beefa18!

@slevenick

Copy link
Copy Markdown
Contributor Author

@modular-magician reassign-reviewer

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from melinath September 8, 2026 20:18
@modular-magician

modular-magician commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 75e962f:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 268 insertions(+)
google-beta provider View Diff 4 files changed, 268 insertions(+)
terraform-google-conversion View Diff 1 file changed, 55 insertions(+)
Open in Cloud Shell View Diff 8 files changed, 234 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
3 3 0 0
Affected Service Packages
  • agenticapplications

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the replaying VCR build log

@slevenick, @melinath VCR tests complete for 75e962f!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants