Skip to content

workstations: add creator policy admin setting - #18933

Open
chucknthem wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
chucknthem:c/workstation-policy-admin
Open

workstations: add creator policy admin setting#18933
chucknthem wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
chucknthem:c/workstation-policy-admin

Conversation

@chucknthem

Copy link
Copy Markdown

Summary

Expose grant_workstation_admin_role_on_create on google_workstations_workstation_config for both the GA and beta providers. Add create-to-update sample coverage so generated acceptance tests verify the field can be changed in place.

Tests

  • make test
  • targeted GA WorkstationConfig generation
  • targeted beta WorkstationConfig generation
  • verified both generated providers contain the schema field and generated update test
workstations: added `grant_workstation_admin_role_on_create` field to `google_workstations_workstation_config` resource

Expose the WorkstationConfig API field in both provider variants and generate create-to-update acceptance coverage.
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 9, 2026
@github-actions
github-actions Bot requested a review from rileykarson September 9, 2026 04:44
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@rileykarson, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@google-cla

google-cla Bot commented Sep 9, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chucknthem

Copy link
Copy Markdown
Author

agentd

Asset Viewer Owner
🖥 Agent   open     open  
📄 Document   open     open  

@github-actions

Copy link
Copy Markdown

@rileykarson This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants