Skip to content

Added AgentConnectivityTemplate resource - #18938

Open
melinath wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
melinath:b-542714422
Open

Added AgentConnectivityTemplate resource#18938
melinath wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
melinath:b-542714422

Conversation

@melinath

@melinath melinath commented Sep 9, 2026

Copy link
Copy Markdown
Member

Fixes b/548696678.
Fixes b/542714422.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_agent_connectivity_template`
networkservices: added `agent_connectivity_template` field to `google_network_services_agent_gateway`

@modular-magician

modular-magician commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 90b07f7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 9 files changed, 1999 insertions(+), 26 deletions(-)
google-beta provider View Diff 9 files changed, 1999 insertions(+), 26 deletions(-)
terraform-google-conversion View Diff 2 files changed, 269 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_network_services_agent_connectivity_template

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
114 109 2 3
Affected Service Packages
  • networkservices

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccNetworkServicesAgentConnectivityTemplate_networkServicesAgentConnectivityTemplateAdvancedExample
  • TestAccNetworkServicesAgentConnectivityTemplate_networkServicesAgentConnectivityTemplateBasicExample
  • TestAccNetworkServicesAgentGateway_networkServicesAgentGatewayFullExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccNetworkServicesAgentConnectivityTemplate_networkServicesAgentConnectivityTemplateBasicExample
❌ Error · Log - TestAccNetworkServicesAgentConnectivityTemplate_networkServicesAgentConnectivityTemplateAdvancedExample
❌ Error · Log - TestAccNetworkServicesAgentGateway_networkServicesAgentGatewayFullExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@melinath VCR tests complete for 90b07f7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants