Skip to content

ces: add whatsapp_config to google_ces_deployment - #18939

Merged
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-549921489
Sep 10, 2026
Merged

ces: add whatsapp_config to google_ces_deployment#18939
slevenick merged 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:mm-b-549921489

Conversation

@slevenick

Copy link
Copy Markdown
Contributor

Added field coverage for channelProfile.whatsappConfig.phoneNumber (and whatsappConfig object) on google_ces_deployment (ces:v1:Deployment).

reference: b/549921489

ces: added `channel_profile.whatsapp_config` field to `google_ces_deployment`

@modular-magician

modular-magician commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e96b6c7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 441 insertions(+), 1 deletion(-)
google-beta provider View Diff 5 files changed, 441 insertions(+), 1 deletion(-)
terraform-google-conversion View Diff 1 file changed, 88 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 131 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
81 79 0 2
Affected Service Packages
  • ces

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccCESDeployment_cesDeploymentWhatsappExample
  • TestAccCESDeployment_whatsappConfig

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccCESDeployment_cesDeploymentWhatsappExample
✅ Log TestAccCESDeployment_whatsappConfig

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick VCR tests complete for e96b6c7!

@slevenick

Copy link
Copy Markdown
Contributor Author

@modular-magician reassign-reviewer

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
github-actions Bot requested a review from roaks3 September 9, 2026 22:31

@roaks3 roaks3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, but LGTM

app = google_ces_app.my-app.name
app_version = google_ces_app_version.my-app-version.id
channel_profile {
channel_type = "API"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not WHATSAPP? Assuming this works, but was just surprised

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It lets us test the functionality without hitting the actual whatsapp API and needing valid keys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants