[Dataproc] Add instance_flexibility_policy to google_dataproc_workflow_template - #18941
Conversation
…w_template Add support for Flexible VMs (instance_flexibility_policy) across master_config, worker_config, and secondary_worker_config in google_dataproc_workflow_template. Design notes and scope boundaries: 1. Flex VM support for node group config is omitted as it is not yet supported in google_dataproc_cluster. 2. provisioning_model_mix is supported exclusively on secondary_worker_config, matching Dataproc API constraints. 3. disk_config under instance_selection_list is kept focused on core disk attributes (boot_disk_type, boot_disk_size_gb, num_local_ssds) to minimize PR complexity.
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit d977f91: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataproc_workflow_template" "primary" {
placement {
managed_cluster {
config {
secondary_worker_config {
disk_config {
boot_disk_size_gb = # value needed
boot_disk_type = # value needed
}
}
worker_config {
disk_config {
boot_disk_type = # value needed
}
}
}
}
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @realdev12, @SirGitsalot VCR tests complete for d977f91! |
SirGitsalot
left a comment
There was a problem hiding this comment.
Please delete this PR, I'm currently reviewing #18944 instead
Purpose
Add support for Dataproc Flexible VMs (
instance_flexibility_policy) togoogle_dataproc_workflow_template. This enables workflow templates to define cluster placements with flexible VM shapes, instance selection lists with priority ranks, disk configurations, and provisioning model mixes (Standard vs. Spot VMs).Implementation Scope & Design Decisions
To maintain parity with the existing
google_dataproc_clusterresource and keep this PR reviewable and well-scoped:google_dataproc_cluster.provisioning_model_mix: Configured exclusively undersecondary_worker_config, adhering to Dataproc API requirements where provisioning model mixing applies only to secondary/preemptible workers.disk_configscope: Restricted to core disk properties (boot_disk_type,boot_disk_size_gb,num_local_ssds) to avoid unnecessary schema complexity while fully covering primary use cases.Tests & Verification
betaandgaproviders.-tags=acctestin both downstream providers with 0 errors.TestAccDataprocWorkflowTemplate_instanceFlexibilityPolicyexercisinginstance_flexibility_policyacross all three instance groups (master_config,worker_config, andsecondary_worker_config), multiple ranks, multi-machine selections, nesteddisk_config, andprovisioning_model_mix.