Skip to content

Add tags to Parameter Manager Resource - #18942

Open
suvidha-malaviya wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
suvidha-malaviya:parameter-manager-tags-support
Open

Add tags to Parameter Manager Resource#18942
suvidha-malaviya wants to merge 2 commits into
GoogleCloudPlatform:mainfrom
suvidha-malaviya:parameter-manager-tags-support

Conversation

@suvidha-malaviya

@suvidha-malaviya suvidha-malaviya commented Sep 10, 2026

Copy link
Copy Markdown

Add tags field to parameter manager resource to allow setting tags on parameter resources at creation time.

b/559010883

parametermanager: added `tags` field to `google_parameter_manager_parameter` and `google_parameter_manager_regional_parameter` to allow setting tags for parameters at creation time

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Sep 10, 2026
@suvidha-malaviya
suvidha-malaviya marked this pull request as ready for review September 10, 2026 05:16
@github-actions
github-actions Bot requested a review from melinath September 10, 2026 05:18
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@melinath

Copy link
Copy Markdown
Member

@modular-magician reassign-reviewer @roaks3

@github-actions
github-actions Bot requested review from roaks3 and removed request for melinath September 10, 2026 15:55
@modular-magician modular-magician added service/parametermanager and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Sep 10, 2026
@modular-magician

modular-magician commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 336592c:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 10 files changed, 215 insertions(+), 12 deletions(-)
google-beta provider View Diff 10 files changed, 215 insertions(+), 12 deletions(-)
terraform-google-conversion View Diff 2 files changed, 34 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
54 52 0 2
Affected Service Packages
  • parametermanager
  • parametermanagerregional

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccParameterManagerParameter_tags
  • TestAccParameterManagerRegionalRegionalParameter_tags

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccParameterManagerParameter_tags
✅ Log TestAccParameterManagerRegionalRegionalParameter_tags

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@suvidha-malaviya, @roaks3 VCR tests complete for 336592c!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants