[Dataproc] Add attached_disk_config and missing disk_config fields to google_dataproc_workflow_template - #18945
Open
realdev12 wants to merge 4 commits into
Conversation
…_dataproc_workflow_template
…_dataproc_workflow_template
…x to secondary_worker_config in google_dataproc_workflow_template
… google_dataproc_workflow_template
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Collaborator
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 642e4f2: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_dataproc_workflow_template" "primary" {
placement {
managed_cluster {
config {
master_config {
disk_config {
attached_disk_config {
disk_type = # value needed
provisioned_iops = # value needed
provisioned_throughput = # value needed
}
boot_disk_provisioned_iops = # value needed
boot_disk_provisioned_throughput = # value needed
}
instance_flexibility_policy {
instance_selection_list {
disk_config {
attached_disk_config {
disk_size_gb = # value needed
disk_type = # value needed
provisioned_iops = # value needed
provisioned_throughput = # value needed
type = # value needed
}
boot_disk_provisioned_iops = # value needed
boot_disk_provisioned_throughput = # value needed
local_ssd_interface = # value needed
}
}
}
}
secondary_worker_config {
disk_config {
attached_disk_config {
disk_type = # value needed
provisioned_iops = # value needed
provisioned_throughput = # value needed
}
boot_disk_provisioned_iops = # value needed
boot_disk_provisioned_throughput = # value needed
}
instance_flexibility_policy {
instance_selection_list {
disk_config {
attached_disk_config {
disk_size_gb = # value needed
disk_type = # value needed
provisioned_iops = # value needed
provisioned_throughput = # value needed
type = # value needed
}
boot_disk_provisioned_iops = # value needed
boot_disk_provisioned_throughput = # value needed
local_ssd_interface = # value needed
}
}
}
}
worker_config {
disk_config {
attached_disk_config {
provisioned_iops = # value needed
provisioned_throughput = # value needed
type = # value needed
}
boot_disk_provisioned_iops = # value needed
boot_disk_provisioned_throughput = # value needed
}
instance_flexibility_policy {
instance_selection_list {
disk_config {
attached_disk_config {
disk_size_gb = # value needed
disk_type = # value needed
provisioned_iops = # value needed
provisioned_throughput = # value needed
type = # value needed
}
boot_disk_provisioned_iops = # value needed
boot_disk_provisioned_throughput = # value needed
local_ssd_interface = # value needed
}
}
}
}
}
}
}
}
Missing doc report (experimental)The following resources have fields missing in documents.
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @realdev12, @rileykarson VCR tests complete for 642e4f2! |
Member
|
@modular-magician reassign-reviewer @SirGitsalot |
github-actions
Bot
requested review from
SirGitsalot
and removed request for
rileykarson
September 10, 2026 18:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
b/559176576
Description
Adds support for
attached_disk_configand missingdisk_configproperties (boot_disk_provisioned_iops,boot_disk_provisioned_throughput, andlocal_ssd_interface) togoogle_dataproc_workflow_templateacrossmaster_config,worker_config,secondary_worker_config, andinstance_selection_list.Key changes:
attached_disk_configblock supporting Hyperdisks (hyperdisk-balanced,hyperdisk-extreme,hyperdisk-ml,hyperdisk-throughput) withtype,disk_type(marked deprecated in favor oftype),disk_size_gb,provisioned_iops, andprovisioned_throughput.typeanddisk_typeduring expansion and flattening to ensure compatibility and prevent drift.attachedDiskConfigs(plural) according to protobuf and REST API specifications.boot_disk_provisioned_iops,boot_disk_provisioned_throughput, andlocal_ssd_interfacetodisk_config.Release Note