Skip to content

parametermanager: add data_crc32c to google_parameter_manager_parameter_version and regional - #18969

Open
slevenick wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:regional-parameter-crc32c
Open

parametermanager: add data_crc32c to google_parameter_manager_parameter_version and regional#18969
slevenick wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
slevenick:regional-parameter-crc32c

Conversation

@slevenick

Copy link
Copy Markdown
Contributor

Reapplies #18940 (reverted in #18968) with regional parameter version support.

The original PR #18940 added data_crc32c to google_parameter_manager_parameter_version and updated the shared flattener template parameter_version_parameter_data.go.tmpl, but did not add the field to google_parameter_manager_regional_parameter_version. When regional parameter versions were read, setting the unmapped data_crc32c in the resource schema caused tests to panic.

This PR adds data_crc32c to both google_parameter_manager_parameter_version and google_parameter_manager_regional_parameter_version, and includes acceptance tests for both resources.

reference: b/559022023

parametermanager: added `data_crc32c` field to `google_parameter_manager_parameter_version` and `google_parameter_manager_regional_parameter_version`

@modular-magician

modular-magician commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 6431a64:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 10 files changed, 291 insertions(+), 2 deletions(-)
google-beta provider View Diff 10 files changed, 291 insertions(+), 2 deletions(-)
terraform-google-conversion View Diff 2 files changed, 22 insertions(+)
Open in Cloud Shell View Diff 4 files changed, 112 insertions(+)

Test report

Analytics

Total Tests Passed Skipped Affected
56 53 0 3
Affected Service Packages
  • parametermanager
  • parametermanagerregional

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccParameterManagerRegionalRegionalParameterVersion_dataCrc32c
  • TestAccParameterManagerRegionalRegionalParameterVersion_regionalParameterVersionWithDataCrc32cExample
  • TestAccParameterManagerRegionalRegionalParameterVersion_update

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccParameterManagerRegionalRegionalParameterVersion_dataCrc32c
✅ Log TestAccParameterManagerRegionalRegionalParameterVersion_regionalParameterVersionWithDataCrc32cExample
✅ Log TestAccParameterManagerRegionalRegionalParameterVersion_update

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@slevenick, @melinath VCR tests complete for 6431a64!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants