Skip to content

test(integration): wait for fluent-bit socket release in TestMetricsPortOverrideEnv - #2400

Draft
rafaelwestphal wants to merge 1 commit into
masterfrom
westphalrafael/fix-metrics-port-override-env-shutdown-delay
Draft

test(integration): wait for fluent-bit socket release in TestMetricsPortOverrideEnv#2400
rafaelwestphal wants to merge 1 commit into
masterfrom
westphalrafael/fix-metrics-port-override-env-shutdown-delay

Conversation

@rafaelwestphal

Copy link
Copy Markdown
Contributor

Description

In TestMetricsPortOverrideEnv on Linux, the test stops the Ops Agent service, writes the systemd drop-in override.conf files to remap ports to 40001/40002, and immediately starts the service.
Because google-cloud-ops-agent.service is a Type=oneshot parent unit, stopping it causes systemd to initiate asynchronous graceful teardown of google-cloud-ops-agent-fluent-bit.service. Fluent Bit has a 5-second shutdown grace period to flush buffers and close connections before releasing its socket.

Related issue

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant