Skip to content

integration_test: move TestParseMultiline* family to transformation_test - #2412

Merged
rafaelwestphal merged 2 commits into
masterfrom
westphalrafael/move-parse-multiline-to-transformation-tests
Aug 31, 2026
Merged

integration_test: move TestParseMultiline* family to transformation_test#2412
rafaelwestphal merged 2 commits into
masterfrom
westphalrafael/move-parse-multiline-to-transformation-tests

Conversation

@rafaelwestphal

Copy link
Copy Markdown
Contributor

Description

The TestParseMultilineFileJava, TestParseMultilineFileJavaPython, TestParseMultilineFileGolangJavaPython, and TestParseMultilineFileMissingParser integration tests are heavy GCE VM tests that only validate multi-line exception stack trace stitching for Go, Java, and Python.

Moving them to transformation_test provides deterministic, millisecond-level multi-engine test coverage for language exception multiline parsing while reducing VM test execution time and eliminating unnecessary GCE resources in CI.

Related issue

Fixes b/553000750

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@rafaelwestphal
rafaelwestphal force-pushed the westphalrafael/move-parse-multiline-to-transformation-tests branch 4 times, most recently from 36308f9 to a90a7a5 Compare August 31, 2026 15:59

@avilevy18 avilevy18 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@franciscovalentecastro franciscovalentecastro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changed : Update to regex the test names (e.g. ".*Multiline.*").

Comment thread transformation_test/transformation_test.go Outdated
The TestParseMultilineFileJava, TestParseMultilineFileJavaPython,
TestParseMultilineFileGolangJavaPython, and TestParseMultilineFileMissingParser
integration tests are heavy GCE VM tests that only validate multi-line exception
stack trace stitching for Go, Java, and Python.

Moving them to transformation_test provides deterministic, millisecond-level
multi-engine test coverage for language exception multiline parsing while
reducing VM test execution time and eliminating unnecessary GCE resources in CI.

Fixes b/553000750
@rafaelwestphal
rafaelwestphal force-pushed the westphalrafael/move-parse-multiline-to-transformation-tests branch from 51efa26 to 6eb874f Compare August 31, 2026 19:06

@franciscovalentecastro franciscovalentecastro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok! LGTM! I'm not seeing Build flakes failures from the transformation tests anymore.

@rafaelwestphal
rafaelwestphal merged commit d539355 into master Aug 31, 2026
74 of 85 checks passed
@rafaelwestphal
rafaelwestphal deleted the westphalrafael/move-parse-multiline-to-transformation-tests branch August 31, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants