Add scalibr os benchmarks - #1044
Conversation
|
Hi @ganochenkodg. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Can we move the code to a dedicated utiltrace package?
There was a problem hiding this comment.
Just checked if it's possible. Unfortunately, no:
- Circular import dependency. The packages package already imports github.com/GoogleCloudPlatform/osconfig/util/utiltrace (in trace.go). So import packages in util/utiltrace/ produces an error - import cycle not allowed
- The benchmark relies on scalibrInstalledPackagesProvider, which is an unexported struct defined inside the packages package and cannot be accessed outside of it without code refactoring
|
/gcbrun |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ganochenkodg, petercieslak The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
/gcbrun |
2 similar comments
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
New test TestScalibrBenchmark to test os/dpkg, os/rpm, os/cos extractors. Sample command to run the test:
Sample output on debian 13: