Add support for UUID, money and other datatypes in postgres - #1395
Open
SaurabhSingh2115 wants to merge 6 commits into
Open
Add support for UUID, money and other datatypes in postgres#1395SaurabhSingh2115 wants to merge 6 commits into
SaurabhSingh2115 wants to merge 6 commits into
Conversation
SaurabhSingh2115
requested review from
bharadwaj-aditya and
darshan-sj
and removed request for
a team
September 2, 2026 06:28
SaurabhSingh2115
marked this pull request as draft
September 2, 2026 06:29
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1395 +/- ##
==========================================
+ Coverage 51.28% 51.50% +0.22%
==========================================
Files 203 203
Lines 22980 23083 +103
Branches 552 552
==========================================
+ Hits 11785 11889 +104
+ Misses 10500 10499 -1
Partials 695 695
🚀 New features to boost your workflow:
|
SaurabhSingh2115
marked this pull request as ready for review
September 3, 2026 04:35
sm745052
reviewed
Sep 8, 2026
| case ddl.String: | ||
| return ddl.Type{Name: ddl.String, Len: ddl.MaxLength}, []internal.SchemaIssue{internal.Widened} | ||
| default: | ||
| return ddl.Type{Name: ddl.String, Len: ddl.MaxLength}, nil |
Contributor
There was a problem hiding this comment.
in default we do not raise the widened warning ?
Author
There was a problem hiding this comment.
fixed added warning for those which don't have native spanner typing
sm745052
reviewed
Sep 8, 2026
| case ddl.String: | ||
| return ddl.Type{Name: ddl.String, Len: ddl.MaxLength}, []internal.SchemaIssue{internal.Widened} | ||
| default: | ||
| return ddl.Type{Name: ddl.Bytes, Len: ddl.MaxLength}, nil |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #545473957
Add explicit type bindings within the conversion engine for all newly supported native types (e.g., UUID, MONEY, OID, BIT) to ensure the system leverages native storage structures.