Skip to content

Add support for default expressions and generated columns for Postgres - #1397

Draft
SaurabhSingh2115 wants to merge 5 commits into
GoogleCloudPlatform:masterfrom
SaurabhSingh2115:generated-columns-and-default-parity
Draft

Add support for default expressions and generated columns for Postgres#1397
SaurabhSingh2115 wants to merge 5 commits into
GoogleCloudPlatform:masterfrom
SaurabhSingh2115:generated-columns-and-default-parity

Conversation

@SaurabhSingh2115

Copy link
Copy Markdown

Fixes #545472954

@SaurabhSingh2115
SaurabhSingh2115 requested a review from a team as a code owner September 7, 2026 13:22
@SaurabhSingh2115
SaurabhSingh2115 requested review from aasthabharill and shreyakhajanchi and removed request for a team September 7, 2026 13:22
@SaurabhSingh2115
SaurabhSingh2115 marked this pull request as draft September 7, 2026 13:22
@codecov

codecov Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.38931% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.39%. Comparing base (a046b9a) to head (8b6e038).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sources/postgres/pgdump.go 79.41% 6 Missing and 8 partials ⚠️
sources/spanner/infoschema.go 0.00% 5 Missing ⚠️
sources/postgres/infoschema.go 91.11% 2 Missing and 2 partials ⚠️
expressions_api/expression_verify.go 0.00% 1 Missing and 1 partial ⚠️
sources/postgres/data.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1397      +/-   ##
==========================================
+ Coverage   51.28%   51.39%   +0.10%     
==========================================
  Files         203      203              
  Lines       22980    23086     +106     
  Branches      552      552              
==========================================
+ Hits        11785    11864      +79     
- Misses      10500    10515      +15     
- Partials      695      707      +12     
Components Coverage Δ
backend-apis 46.10% <ø> (ø)
backend-library 57.03% <79.38%> (+0.11%) ⬆️
cli 26.62% <ø> (ø)
frontend 39.34% <ø> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/test_util.go 30.40% <100.00%> (+1.66%) ⬆️
sources/common/infoschema.go 8.28% <100.00%> (+0.50%) ⬆️
sources/common/toddl.go 69.41% <100.00%> (ø)
sources/mysql/data.go 79.08% <100.00%> (+0.27%) ⬆️
expressions_api/expression_verify.go 67.84% <0.00%> (-0.61%) ⬇️
sources/postgres/data.go 81.63% <0.00%> (-0.68%) ⬇️
sources/postgres/infoschema.go 84.14% <91.11%> (-0.56%) ⬇️
sources/spanner/infoschema.go 5.23% <0.00%> (-0.04%) ⬇️
sources/postgres/pgdump.go 73.91% <79.41%> (+0.17%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pull-request-size pull-request-size Bot added size/XL and removed size/L labels Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant