Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
mtx_initfails,DmLoader_createfrees the new loader but leaves the caller's output pointer pointing to freed memory. Later resolver registration or release can then access that allocation.Assign the output pointer only after initialization succeeds. Allocation and mutex initialization failures now leave it unchanged.
Found while investigating an OpenGothic Android shutdown crash. The startup log reported loader creation failure without its result code; the mutex failure path was identified by inspecting the code. This is the library fix suggested in Try/OpenGothic#985.
Validation: dmusic static Release build passed with MSVC.