Uses Data inputs and outputs#11
Merged
Merged
Conversation
It also changes the error pathway to close immediately instead of sending a formatted message.
NeedleInAJayStack
force-pushed
the
feat/data-centric-view
branch
from
b3235ac to
efa0bb6
Compare
Also change the error code enum to `internal` visibility
NeedleInAJayStack
force-pushed
the
feat/data-centric-view
branch
from
efa0bb6 to
66e5edd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the
Messenger,Server, andClientto operate onDataas opposed toString. This allows for optimizations like avoiding a Data <-> String conversion when using a WebSocket library that exposes passing and receivingtextmessages as aDataorByteBuffers. It also better matches the paradigm that this package operates on encoded JSON, which in Swift is typically aDatatype.This also adjusts error behavior to avoid sending error messages as
textframes in the format of"\(code): \(reason)", and removes the corresponding server handling. This was a holdover from using a WebSocket package that didn't expose passing a reason within a close frame.Finally, it aligns error codes to match those listed in the spec.