chore(m3): CodeRabbit CHANGELOG nits + CI anchor build log artifact#16
Conversation
…g artifact Two follow-ups from PR #15's review and post-merge investigation: 1. CHANGELOG.md fixes (CodeRabbit's 2 minor findings on PR #15): - "init_if_needed Anchor feature" added section rewritten to describe the Anchor 0.32-compatible lazy init via manual create_account CPI that actually shipped (PR #15's design replaced PR #12's init_if_needed approach to satisfy Anchor 0.32's "Cannot use init on SystemAccount" check). - "lp_holder_pool_vault migrated to SystemAccount" entry split into two cases: claim_lp_proceeds gets SystemAccount (read-only, safe under 0.32); salvage_pool gets UncheckedAccount + manual CPI. - Verification status section updated to reflect locally-passed checks (fmt, clippy, 20/20 tests, BPF compile) plus the known CI anchor build failure being tracked. 2. CI workflow gains an artifact upload on anchor build failure. The anchor build step now tees stdout/stderr to /tmp/anchor-build.log, and on failure that file is uploaded as a workflow artifact via actions/upload-artifact@v4. Needed because the Composio integration this repo uses for programmatic CI inspection does not expose log download endpoints; the only way to see the actual anchor build error message has been the GitHub Actions web UI. After this PR merges and a future CI run fails on anchor build, the log artifact can be downloaded for offline diagnosis. No source changes. No on-chain semantics change.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds CI build-log capture for failure diagnostics and updates ChangesBuild Infrastructure and Verification
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Two small follow-ups before m5 work begins.
1. CHANGELOG.md fixes (CodeRabbit's 2 nits from PR #15)
Both findings were minor 🟡 doc-accuracy issues, no code defects. Addressed:
init_if_neededAnchor feature entry rewritten to describe what actually shipped: Anchor 0.32-compatible lazy init via manualsystem_program::create_accountCPI. PR feat(grave-vault): m3 salvage_pool pre-flight + cert freshness gates #12's originalinit_if_neededdesign was incompatible with Anchor 0.32's new "Cannot use init on SystemAccount" check, and PR feat(grave-vault): m3 salvage_pool pre-flight + cert freshness gates (rebased) #15 already replaced it — the CHANGELOG just hadn't caught up.lp_holder_pool_vaultmigration entry split into two cases:claim_lp_proceeds: SystemAccount (read-only path, safe under 0.32)salvage_pool: UncheckedAccount + manual CPI (CodeRabbit's specific suggestion)2. CI workflow gains anchor-build log artifact upload
The current CI workflow runs
anchor buildand on failure the only diagnostic surface is the GitHub Actions web UI log page. The Composio integration this repo uses for programmatic CI inspection does not expose log download (verified across multiple action names — all return "not available"). So debugging the post-PR-#15 anchor build regression has been blind.This PR teases anchor build's stdout/stderr to
/tmp/anchor-build.logand adds anactions/upload-artifact@v4step that runsif: failure(). After this PR lands and a future CI run fails on anchor build, the log artifact will be downloadable for offline diagnosis.Why two changes in one PR
Both are small, neither touches program source, and the anchor build log artifact is the diagnostic mechanism we'll use to unblock m5 work. Keeping them together avoids two trivial PRs.
Verification
No source changes. Locally on rust 1.91.1 + anchor 0.32.1 + solana 3.0.10 + platform-tools v1.54:
Test plan
anchor-build-logartifact via GitHub Actions UI or API.Refs
Summary by CodeRabbit
Chores
Documentation