-
Notifications
You must be signed in to change notification settings - Fork 58
refactor[next]: Split compilation into a actual compilation and loading of the compilation artifact #2587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
havogt
wants to merge
40
commits into
GridTools:main
Choose a base branch
from
havogt:worktree-otf-build-finalize-split
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor[next]: Split compilation into a actual compilation and loading of the compilation artifact #2587
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
6a35549
refactor[next]: otf split build and load
havogt d251057
refactorings to combine load+decoration
havogt b8efa44
BuildArtifact can materialize() itself
havogt 915ce27
remove OTFCompileWorkflow
havogt c51ac55
cleanup docstrings
havogt 9b842e2
refactor: remove lazy import
havogt c022bde
apply pre-commit
havogt a107dd6
update roundtrip
havogt fa18067
Merge remote-tracking branch 'upstream/main' into worktree-otf-build-…
havogt efecdf5
separate gtfn from generic compiler
havogt 68ead69
don't serialize/deserialize dace in the same process
havogt 4702660
don't search for sdfg in materialize
havogt 77b6235
restore generic compiler
havogt 3869d67
cleanup
havogt 9017b33
more cleanup
havogt 5bffec0
add tests
havogt 7f219d7
cleanup
havogt 69c5ae8
avoid decoration needs picklable
havogt e05a336
cleanup
havogt 7e9fa08
cleanup
havogt 8f35cb7
Build->Compile, materialize->load
havogt 29508bf
cleanup
havogt 9f4e776
use tmp_path fixture
havogt 9c9234d
refactor roundtrip to resepect picklability
havogt 528dcd5
Merge branch 'main' into worktree-otf-build-finalize-split
havogt edd9e93
sdfg as part of artifact (because of upcoming change)
havogt 25f8cc1
Merge upstream/main into worktree-otf-build-finalize-split
havogt 57c55ba
refactor[next]: lift dace live-program cache out of CompilationArtifact
havogt a3e2234
docs: drop reST roles from docstrings; emphasize Google style in AGEN…
havogt 21de820
docs: drop remaining reST roles from PR-introduced docstrings
havogt c125a2a
refactor[next]: drop Path/str round-trip in DaCeCompiler
havogt 3c65696
refactor[next]: store library_path on DaCeCompilationArtifact
havogt 1a13a63
docs[next]: explain why DaCeCompilationArtifact has _live_program_cache
havogt c9dc7be
docs[next]: TODO to drop _live_program_cache if dace stops renaming
havogt 13ca4f8
Merge remote-tracking branch 'upstream/main' into worktree-otf-build-…
havogt 46a2578
feat[next]: make CompilationArtifact Protocol runtime-checkable
havogt bce7122
refactor[next]: drop unused CompilerFactory
havogt d8c1789
refactor[next]: skip dlopen at dace compile time
havogt f9e7f25
refactor[next]: drop _live_program_cache in dace compilation artifact
havogt 0451bff
Merge remote-tracking branch 'upstream/main' into worktree-otf-build-…
havogt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.