feat[cartesian]: DaCe optimal for/map schedule#2628
Open
FlorianDeconinck wants to merge 1 commit into
Open
Conversation
… optimal parallel strategy
Contributor
|
I think the failing gpu-tests are due to a cuda-codgen issue in DaCe. From what I understand, this test case triggers the codepath here which inserts a global grid sync into a merged kernel. The grid sync insertion in successful, but the We could work around by slightly changing the test scenario. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reworked the based scheduling of the loops in OIR -> TreeIR to simplify the code and introduce an optimal scheduling for parallelism:
_resolve_loop_scheduleomp for parallelon CPU and plain kernel for CUDA)This should be covered by the current unit tests