docs: Update PR review instructions#2634
Conversation
Added guidelines for labeling PRs as 'good to merge'. This is a experiment.
There was a problem hiding this comment.
Pull request overview
Updates the repository’s Copilot code review guidance by adding a new “Summary” section describing when a PR can be considered “good to merge”.
Changes:
- Add a “## Summary” section to codify a lightweight “good to merge” labeling heuristic.
- Define the heuristic in terms of review findings plus a small-change threshold focused on
srcchanges.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
egparedes
left a comment
egparedes
left a comment
There was a problem hiding this comment.
The new instructions look good to me but, if I understand this file correctly, it only affects github copilot. I think we should also add similar instructions for other agents (maybe in AGENTS.md or maybe in another markdown file referenced from AGENTS), since they could also interact with the PR on github trough GitHub MCP or directly with API calls if configured properly at the user side.
It might seem a bit overkill, but for example I've already run out of copilot credits this month, and I can't request more reviews, so I guess the new instructions would never affect my PRs until the next billing cycle
|
My idea with this was to have one accepted authority (github copilot) to do the judgement, but indeed the new usage limits will not allow to do this for long, I will soon run out as well... |
Added guidelines for labeling PRs as 'good to merge'. This is a experiment.