fix(secrets): accept preserved webhook keys - #22
Closed
orga-agent[bot] wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Superseded by the cutover decision to rotate a fresh dev email-hook secret and isolate the Cloudflare dev binding. This compatibility relaxation is no longer needed; please close without merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v1,whsec_payload when adopting an existing email-hook SecretThis unblocks the FlickNote dev migration without rotating the live email-hook signing secret. GoTrue itself accepts non-32-byte Standard Webhooks payloads; the prior exact-length check was stricter than the consumer contract.
Verification
go test ./...git diff --check