feat: add defaultReason prop to OffCycleReasonSelection - #2619
Open
krisxcrash wants to merge 2 commits into
Open
feat: add defaultReason prop to OffCycleReasonSelection#2619krisxcrash wants to merge 2 commits into
krisxcrash wants to merge 2 commits into
Conversation
Lets standalone consumers of the reason picker start with "bonus" or "correction" pre-selected, matching the pre-selection support OffCycleCreation already has via its own payrollType prop. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
krisxcrash
marked this pull request as ready for review
August 21, 2026 22:32
serikjensen
requested changes
Aug 24, 2026
serikjensen
left a comment
serikjensen
left a comment
Member
There was a problem hiding this comment.
My rec on this one would be to either hold off for it to be identified in the test fest. If we do decide to fix this now, i think we should update to use defaultValues on the form consistent with the other component APIs rather than setting it via defaultReason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OffCycleReasonSelectionhardcoded its form to start with no reason selected, with no way for a standalone consumer to pre-select "bonus" or "correction".OffCycleCreation(the all-in-one component) already supports this via its ownpayrollTypeprop, soOffCycleReasonSelectionwas the one place this capability was missing for anyone using the reason picker on its own.defaultReasonprop (named consistently with the existingdefaultPolicyTypeconvention onPolicyTypeSelector), threaded into the internal form'sdefaultValues. Non-breaking: omitting the prop keeps the existing empty-selection behavior.Test plan
npm run test -- --run src/components/Payroll/OffCycleReasonSelection/OffCycleReasonSelection.test.tsx— added a test asserting the radio matchingdefaultReasonis pre-checkednpx tsc --noEmitandnpx eslinton touched filesWithDefaultReasonstory toOffCycleReasonSelection.stories.tsx🤖 Generated with Claude Code