fix(SDK-1173): give contractor row action-menu buttons a row-specific accessible name - #2647
Open
dmortal wants to merge 2 commits into
Open
fix(SDK-1173): give contractor row action-menu buttons a row-specific accessible name#2647dmortal wants to merge 2 commits into
dmortal wants to merge 2 commits into
Conversation
… accessible name
The onboarding-completion and management contractor lists' per-row
hamburger menu trigger used a generic accessible name ("Open menu" /
"Contractor actions menu") that didn't identify which row it acted on,
failing WCAG 4.1.2 per an external accessibility audit. It now reads
"Actions for <contractor name>", matching the pattern already used by
the state taxes list.
dmortal
marked this pull request as ready for review
August 26, 2026 17:24
serikjensen
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a Critical WCAG 4.1.2 (Name, Role, Value) accessibility finding: the per-row "Actions" hamburger menu button on the contractor onboarding-completion and management lists announced a generic, non-row-specific accessible name to screen readers, so users couldn't tell which contractor's menu they were opening.
Changes
ContractorListView.tsx(onboarding) andManagementContractorListView.tsx(management) now pass a per-rowtriggerLabeltoHamburgerMenu, interpolating the contractor's display name.hamburgerTitletranslation key in both Contractor list namespaces to"Actions for {{name}}", matching the existing pattern used by the state taxes list (Company.StateTaxes.json).Related
Testing
npm run i18n:generate— regenerated translation types, no errors.npm run test -- --run src/components/Contractor/ContractorList/onboarding/ContractorList.test.tsx src/components/Contractor/ContractorList/management/ManagementContractorList.test.tsx— 25 passed.npm run test -- --run(full suite) — 351 test files, 3853 passed (1 pre-existing unrelated expected fail).npx tsc --noEmit— no type errors.