Conversation
Signed-off-by: Bhanuja Bhatt <bhbhatt@redhat.com>
kostyanf14
requested changes
Sep 3, 2026
kostyanf14
left a comment
kostyanf14
left a comment
Contributor
There was a problem hiding this comment.
virtio-rng-pci-modern - is not a real device
disable-legacy=on,disable-modern=off should be a CLI option for AutoHCK to add this automatically for proper device
Like: --discard-granularity, --virtio-vectors, --aio-threads.
@YanVugenfirer, what is our decision about modern/legacy testing?
@bhbhatt if we need this, please rework for all virtio devices that support modern/legacy modes.
Contributor
Author
|
@YanVugenfirer can you please clarify if we need all three modes or specific modes thanks! |
bhbhatt
marked this pull request as draft
September 11, 2026 05:02
Contributor
|
@bhbhatt As there still no decision on testing of modern and transitional devices, I suggest to migrate existing kar tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern means QEMU must start virtio-rng with disable-legacy=on and disable-modern=off. That is a boot flag.
The default -d viorng device does not set those flags. The test JSON cannot add them after the VM is up.