VIRTWINKVM-2898: Exclude usb-tablet if virtio-mouse/virtio-tablet is attached - #1135
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
harshapa-rh
force-pushed
the
usb-tablet-virtio-mouse
branch
from
September 10, 2026 06:40
cf1fad2 to
4f0679f
Compare
kostyanf14
requested changes
Sep 10, 2026
kostyanf14
left a comment
kostyanf14
left a comment
Contributor
There was a problem hiding this comment.
missing "signoff-by" in commit
…attached Signed-off-by: Harshal Patil <harshapa@redhat.com>
harshapa-rh
force-pushed
the
usb-tablet-virtio-mouse
branch
from
September 10, 2026 08:12
4f0679f to
4b310e3
Compare
Contributor
|
ok to test |
There was a problem hiding this comment.
🟡 Changes recommended
The new default-device selection branches lack regression coverage in the existing QemuMachine RSpec suite.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Moves the default USB tablet into device selection so it is omitted when a VirtIO pointing device is attached.
Changes:
- Adds configurable
usb-tabletfallback behavior. - Classifies VirtIO mouse/tablet devices as pointing devices.
- Removes the unconditional USB tablet command.
File summaries
| File | Description |
|---|---|
qemu_machine.rb |
Conditionally adds the default tablet. |
qemu_machine.json |
Configures the default tablet device. |
virtio-tablet-pci.json |
Marks the device as a mouse. |
virtio-mouse-pci.json |
Marks the device as a mouse. |
usb-tablet.json |
Defines the default USB tablet. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kostyanf14
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.