Skip to content

Replace deprecated dsaltares/fetch-gh-release-asset with robinraju/re…#258

Open
lrknox wants to merge 2 commits into
HDFGroup:masterfrom
lrknox:fix_deprecated_punycode
Open

Replace deprecated dsaltares/fetch-gh-release-asset with robinraju/re…#258
lrknox wants to merge 2 commits into
HDFGroup:masterfrom
lrknox:fix_deprecated_punycode

Conversation

@lrknox
Copy link
Copy Markdown
Collaborator

@lrknox lrknox commented Jun 1, 2026

…lease-downloader

Fixes DEP0040/DEP0169 deprecation warnings and "Could not find asset id" error caused by the unmaintained dsaltares action. Replaces all 25 usages across 5 workflow files with robinraju/release-downloader@v1, mapping repo→repository, version tags/TAG→tag TAG, file→fileName, and target→out-file-path.

…lease-downloader

Fixes DEP0040/DEP0169 deprecation warnings and "Could not find asset id" error
caused by the unmaintained dsaltares action. Replaces all 25 usages across 5
workflow files with robinraju/release-downloader@v1, mapping repo→repository,
version tags/TAG→tag TAG, file→fileName, and target→out-file-path.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
HDF5 release tags changed from hdf5-x.y.z to x.y.z, but release filenames
still use the hdf5- prefix (e.g. hdf5-2.1.1-win-vs2022_cl.zip).

- release.yml: prefix use_hdf with hdf5- so filenames resolve correctly;
  pass new hdf_tag for the bare version number used in git tag lookup
- cmake-ctest.yml, cmake-bintest.yml: add hdf_tag input and use it for the
  release asset tag: field, keeping use_hdf for filename construction

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@brtnfld brtnfld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mismatch in .github/workflows/cmake-script.yml

While cmake-bintest.yml and cmake-ctest.yml were updated with the new hdf_tag logic, .github/workflows/cmake-script.yml was only partially modified. It was migrated to use robinraju/release-downloader, but did not receive the hdf_tag input changes.

Under the "Get hdf5 release" steps in cmake-script.yml, the code currently does this:

- name: Get hdf5 release
        if: ${{ (inputs.use_environ == 'release') }}
        uses: robinraju/release-downloader@v1
        with:
          repository: 'HDFGroup/hdf5'
          tag: '${{ inputs.use_hdf }}'
          fileName: '${{ inputs.use_hdf }}-win-vs2022_cl.zip'
          token: ${{ github.token }}

Why this will fail:

If inputs.use_hdf is passed as hdf5-2.1.1 (to match the filename hdf5-2.1.1-win-vs, the action will attempt to search for the release tag hdf5-2.1.1. This will fail with a 404 Not Found because the official repository tag is 2.1.1

If inputs.use_hdf is passed as 2.1.1 (to match the tag), the download will search for the asset 2.1.1-win-vs2022_cl.zip, which does not exist.

Suggested Fix:
Update .github/workflows/cmake-script.yml to match the patterns used in cmake-bintest.yml and cmake-ctest.yml:

Add hdf_tag to the inputs of cmake-script.yml:
    hdf_tag:
            description: "The hdf5 release tag for asset download (version only, without hdf5- prefix)"
            required: false
            type: string
            default: ''
Update the tag fields under the release download steps:
  - name: Get hdf5 release
           if: ${{ (inputs.use_environ == 'release') }}
           uses: robinraju/release-downloader@v1
           with:
             repository: 'HDFGroup/hdf5'
             tag: '${{ inputs.hdf_tag }}'
             fileName: '${{ inputs.use_hdf }}-win-vs2022_cl.zip'
             token: ${{ github.token }}
(Apply this update to all other release-download blocks for Linux and macOS inside cmake-script.yml)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants