Replace deprecated dsaltares/fetch-gh-release-asset with robinraju/re…#258
Open
lrknox wants to merge 2 commits into
Open
Replace deprecated dsaltares/fetch-gh-release-asset with robinraju/re…#258lrknox wants to merge 2 commits into
lrknox wants to merge 2 commits into
Conversation
…lease-downloader Fixes DEP0040/DEP0169 deprecation warnings and "Could not find asset id" error caused by the unmaintained dsaltares action. Replaces all 25 usages across 5 workflow files with robinraju/release-downloader@v1, mapping repo→repository, version tags/TAG→tag TAG, file→fileName, and target→out-file-path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
HDF5 release tags changed from hdf5-x.y.z to x.y.z, but release filenames still use the hdf5- prefix (e.g. hdf5-2.1.1-win-vs2022_cl.zip). - release.yml: prefix use_hdf with hdf5- so filenames resolve correctly; pass new hdf_tag for the bare version number used in git tag lookup - cmake-ctest.yml, cmake-bintest.yml: add hdf_tag input and use it for the release asset tag: field, keeping use_hdf for filename construction Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
brtnfld
requested changes
Jun 2, 2026
Contributor
brtnfld
left a comment
There was a problem hiding this comment.
Mismatch in .github/workflows/cmake-script.yml
While cmake-bintest.yml and cmake-ctest.yml were updated with the new hdf_tag logic, .github/workflows/cmake-script.yml was only partially modified. It was migrated to use robinraju/release-downloader, but did not receive the hdf_tag input changes.
Under the "Get hdf5 release" steps in cmake-script.yml, the code currently does this:
- name: Get hdf5 release
if: ${{ (inputs.use_environ == 'release') }}
uses: robinraju/release-downloader@v1
with:
repository: 'HDFGroup/hdf5'
tag: '${{ inputs.use_hdf }}'
fileName: '${{ inputs.use_hdf }}-win-vs2022_cl.zip'
token: ${{ github.token }}
Why this will fail:
If inputs.use_hdf is passed as hdf5-2.1.1 (to match the filename hdf5-2.1.1-win-vs, the action will attempt to search for the release tag hdf5-2.1.1. This will fail with a 404 Not Found because the official repository tag is 2.1.1
If inputs.use_hdf is passed as 2.1.1 (to match the tag), the download will search for the asset 2.1.1-win-vs2022_cl.zip, which does not exist.
Suggested Fix:
Update .github/workflows/cmake-script.yml to match the patterns used in cmake-bintest.yml and cmake-ctest.yml:
Add hdf_tag to the inputs of cmake-script.yml:
hdf_tag:
description: "The hdf5 release tag for asset download (version only, without hdf5- prefix)"
required: false
type: string
default: ''
Update the tag fields under the release download steps:
- name: Get hdf5 release
if: ${{ (inputs.use_environ == 'release') }}
uses: robinraju/release-downloader@v1
with:
repository: 'HDFGroup/hdf5'
tag: '${{ inputs.hdf_tag }}'
fileName: '${{ inputs.use_hdf }}-win-vs2022_cl.zip'
token: ${{ github.token }}
(Apply this update to all other release-download blocks for Linux and macOS inside cmake-script.yml)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lease-downloader
Fixes DEP0040/DEP0169 deprecation warnings and "Could not find asset id" error caused by the unmaintained dsaltares action. Replaces all 25 usages across 5 workflow files with robinraju/release-downloader@v1, mapping repo→repository, version tags/TAG→tag TAG, file→fileName, and target→out-file-path.