Conversation
This (partially) reverts commit 0b2b0da.
Contributor
|
I do not have the original repro, but (probably) the same project build with your branche + development, I have the following errors. (no error on other tested projects) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unreflective iterators were broken in 0b2b0da, because the iterator fields are now accessed via dynamic field lookup instead of direct calls (which is also less optimal in general). This partially reverts 4a181fd, which fixes #12369.
Presumably, the original commit was intended to fix: #11891 (comment), so this probably requires testing (and ideally a proper test case) to prevent that issue from returning. @yuxiaomao would you be able to check if this causes that
has no field hasNext()error to return?