Conversation
Contributor
Author
|
With more tests there is s.onItem = function(item) { trace(item + " !"); }fail with So added a new fix (I removed the local optimization that skip nullcheck in Cpp, jvm are really failing the tests. Fix suggested by Claude (seems that previously a new field is created for the dynamic function, which isn't good. But I'm not able to understand much of it.) |
Member
|
The JVM fix looks a bit silly, surely this should become part of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a rare case in our codebase, and it doesn't really cause problem at runtime. However it fail hl-check
Fail hl-check at:
Before fix
After fix