Skip to content

Fix issues #117 #118 #119 #120 - Implement Testing Infrastructure - #390

Merged
Mikey-222 merged 1 commit into
Hel-Phone:mainfrom
circleboyslimited:fix/issues-117-118-119-120
Aug 26, 2026
Merged

Fix issues #117 #118 #119 #120 - Implement Testing Infrastructure#390
Mikey-222 merged 1 commit into
Hel-Phone:mainfrom
circleboyslimited:fix/issues-117-118-119-120

Conversation

@circleboyslimited

@circleboyslimited circleboyslimited commented Aug 26, 2026

Copy link
Copy Markdown

Summary

This PR implements a comprehensive testing infrastructure for the HelPhone project, addressing four testing-related issues.

Issues Fixed

#120: Set Up GitHub Actions CI Pipeline

  • Impact: No automated testing on pull requests
  • Fix: Created .github/workflows/ci.yml with full CI pipeline
  • Features: Runs on push/PR to main/develop, includes linting, tests, coverage, and build
  • Files: .github/workflows/ci.yml

#119: Configure Test Coverage Reporting

  • Impact: No visibility into code coverage
  • Fix: Configured Vitest coverage with v8 provider in vite.config.js
  • Features: 70% minimum thresholds, multiple report formats (text, json, html, lcov), coverage uploaded to Codecov
  • Files: vite.config.js, package.json (added test:coverage script)

#117: Set Up Express API Endpoint Tests

  • Impact: Backend server endpoints lack tests
  • Fix: Created comprehensive integration tests for Express server
  • Coverage: Rate limiter, error handler, preferences API, feedback API
  • Files: test/server-api.test.js, package.json (added supertest dependency)

#118: Implement Jest Snapshot Tests for Shared UI Components

  • Impact: No snapshot testing for UI components
  • Fix: Created snapshot test infrastructure with examples for Help and Ranking pages
  • Features: Template structure for future shared components with TODO guidance
  • Files: test/snapshots.test.jsx, package.json (added test:update-snapshots script)

Testing

  • All new test files follow Vitest patterns
  • Express tests use supertest for HTTP assertions
  • Snapshot tests use @testing-library/react
  • CI pipeline validates all tests run successfully

Dependencies Added

  • @vitest/coverage-v8: Coverage reporting
  • supertest: HTTP assertion testing for Express endpoints

Closes #117
Closes #118
Closes #119
Closes #120

…-Phone#119 Hel-Phone#120

- Issue Hel-Phone#120: Created GitHub Actions CI pipeline (.github/workflows/ci.yml)
  Runs tests, linting, coverage, and build on every PR and push to main/develop

- Issue Hel-Phone#119: Configured test coverage reporting in vite.config.js
  Added coverage thresholds (70%) and coverage script to package.json
  Coverage reports in text, json, html, and lcov formats

- Issue Hel-Phone#117: Set up Express API endpoint tests (test/server-api.test.js)
  Added comprehensive tests for rate limiter, error handler, preferences API, and feedback API
  Added supertest as dev dependency for HTTP assertion testing

- Issue Hel-Phone#118: Implemented snapshot tests for UI components (test/snapshots.test.jsx)
  Created snapshot tests for Help and Ranking pages as templates
  Added test:update-snapshots script to package.json
  Includes TODO guidance for future shared component snapshot tests
@drips-wave

drips-wave Bot commented Aug 26, 2026

Copy link
Copy Markdown

@circleboyslimited Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Mikey-222
Mikey-222 merged commit 3a8a8ec into Hel-Phone:main Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants