test(persistence): pin Elasticsearch test image to 7.17.29 - #948
Merged
Conversation
testcontainers-modules defaults to elasticsearch:7.16.1, whose bundled JDK 17.0.1 crashes at startup on cgroup v2 hosts without a mounted controller (e.g. Docker Desktop's linuxkit VM) with `NullPointerException ... CgroupInfo.getMountPoint() ... "anyController" is null` (JDK-8272124, fixed in 17.0.2). Every 7.16.x tag ships the broken JDK, so pin the latest 7.17 release in both ES test suites. It keeps the 7.x API surface and still logs the `[YELLOW] to [GREEN]` ready line the module waits on; 8.x does not, so a plain bump to 8.x would hang the startup wait. Claude-Session: https://claude.ai/code/session_01Pk7MNEXTSMZS3utwcbWeZN
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins the shared Elasticsearch testcontainer in
elasticsearch_tests.rsands3_es_tests.rsto image tag7.17.29via a newES_IMAGE_TAGconstant.testcontainers-modulesdefaults toelasticsearch:7.16.1, whose bundled JDK 17.0.1 crashes at JVM startup on cgroup v2 hosts without a mounted controller (Docker Desktop's linuxkit VM) withNullPointerException: Cannot invoke "jdk.internal.platform.CgroupInfo.getMountPoint()" because "anyController" is null(JDK-8272124, fixed in 17.0.2). Every 7.16.x tag ships the broken JDK, so everyes_integration::*test fails at once on such hosts.7.17.29 keeps the 7.x API surface and still logs the
[YELLOW] to [GREEN]ready message the module waits on. 8.x does not log that line, so a plain tag bump to 8.x would hang the startup wait.Notes
elasticsearch:7.17.29.https://claude.ai/code/session_01Pk7MNEXTSMZS3utwcbWeZN