test: add coverage for GridGenerator.ring and .spiral#123
Open
dusan-maintains wants to merge 1 commit into
Open
test: add coverage for GridGenerator.ring and .spiral#123dusan-maintains wants to merge 1 commit into
dusan-maintains wants to merge 1 commit into
Conversation
StantonMatt
reviewed
Jun 2, 2026
StantonMatt
left a comment
There was a problem hiding this comment.
Checked this locally on Node v22.22.2 / npm 10.9.7.
The targeted command from the PR passes:
npx jest test/src/GridGenerator.test.tsx --runInBandResult: 9/9 GridGenerator tests passed, including the new ring and spiral coverage.
I also ran the full suite:
CI=1 npm test -- --runInBandResult: 7 suites passed, 36 tests passed, 1 skipped, 9 snapshots passed.
The remaining skipped test is Hexagon should render correctly with default props in test/src/Hexagon/Hexagon.test.tsx, so it is separate from the old commented-out GridGenerator ring/spiral placeholder that this PR replaces. No PR checks are currently configured/running, so local verification is the evidence here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GridGenerator.ring()andGridGenerator.spiral().Why
Test Plan
npx jest test/src/GridGenerator.test.tsx --runInBandNotes