feat: hippocampal memory system, improved tool/subagent error messages, YOLO mode cleanup#2933
feat: hippocampal memory system, improved tool/subagent error messages, YOLO mode cleanup#2933cy2311 wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Thanks @cy2311 for taking the time to contribute. This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered. Please read |
There was a problem hiding this comment.
Code Review
This pull request updates the YOLO mode prompt markdown file by adding an instruction to execute actions directly without announcing or restating the current mode. It also changes the header level from H2 to H5. The reviewer recommends keeping the H2 header level to maintain consistency with other mode prompts.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| @@ -1,4 +1,4 @@ | |||
| ## Mode: YOLO | |||
| ##### Mode: YOLO | |||
There was a problem hiding this comment.
The header level was changed from ## (H2) to ##### (H5). To maintain consistency with other mode prompts (such as ## Mode: Agent and ## Mode: Plan) and to keep a clean hierarchy in the composed system prompt, it is recommended to keep this as an H2 header.
| ##### Mode: YOLO | |
| ## Mode: YOLO |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
c736324 to
63a0b3e
Compare
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
@cy2311 — thank you, there's a lot of good work here. We'd like to take it, but in pieces, because it bundles two very different kinds of change: The three fixes are wanted now. The YOLO-mode announcement suppression (#2922), the The memory crate needs a design conversation first. A new Closing nothing here — this PR can stay open as the reference while the split PRs land. |
This PR contains four fixes/features across two branches of work:
Bug Fixes
1. YOLO mode verbosity (#2922)
Added
"Do not announce or restate the current mode between actions — just execute."to the YOLO mode prompt to suppress repeated mode announcements before each tool call.2. Tool error message clarity (#2657)
Removed generic suffixes from
format_tool_error()when the underlying error already explains the cause (mode restriction, shell access, etc.), so the agent can tell exactly why a tool is unavailable.3. Subagent session name conflicts (#2656)
Added elapsed time (
started Xs ago) to the session-name-conflict error message, so the agent can distinguish between a running agent, a completed one, or a stale session.Feature
4. Hippocampal Memory System (#2935)
New
crates/memory/crate with SQLite-backed structured memory store:entitiestable: Files, PRs, issues, concepts, decisionsrelationstable: Directed edges with kind + strength (e.g.dispatch.rs ── part_of ──▶ PR #2933)factstable: Standalone statements with FTS5 full-text search for pattern-completion queriesmemorizetool: Agent stores a structured fact with importance score and optional entity bindingrecalltool: Agent queries memory by keyword, gets facts + related entities + graph relationshipsprune_low_importance_facts()removes old/low-value factsmemory_db_pathinEngineConfigFiles Changed