Skip to content

fix(tui): guide long shell work to background#2947

Merged
Hmbown merged 1 commit into
Hmbown:mainfrom
cyq1017:codex/codewhale-2939-shell-background-gpt55
Jun 10, 2026
Merged

fix(tui): guide long shell work to background#2947
Hmbown merged 1 commit into
Hmbown:mainfrom
cyq1017:codex/codewhale-2939-shell-background-gpt55

Conversation

@cyq1017

@cyq1017 cyq1017 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Fixes #2939.

Summary

  • spell out the >5 second threshold for shell work in the model prompt
  • align the exec_shell background schema with task_shell_start / wait guidance
  • add prompt and schema coverage for the guidance

Verification

  • CARGO_TARGET_DIR=/tmp/codewhale-2939-supervisor-target cargo test -p codewhale-tui test_exec_shell_schema_guides_gt_five_second_work_to_background
  • CARGO_TARGET_DIR=/tmp/codewhale-2939-supervisor-target cargo test -p codewhale-tui composed_prompt_keeps_shell_guidance_when_shell_tools_are_available
  • cargo fmt --all -- --check
  • git diff --check HEAD^..HEAD

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the system prompts, tool descriptions, and associated tests to explicitly define "long-running" shell commands as those expected to take more than 5 seconds. This establishes a concrete threshold for when background execution (via task_shell_start or background: true) should be preferred over foreground execution. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@cyq1017 cyq1017 marked this pull request as ready for review June 9, 2026 22:37

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@Hmbown Hmbown merged commit 40f9a8b into Hmbown:main Jun 10, 2026
10 checks passed
@Hmbown

Hmbown commented Jun 10, 2026

Copy link
Copy Markdown
Owner

Merged — thanks @cyq1017. This is the prompt-side half of #2939 (agent stalling on long-running shell commands); the >5s rule in both prompt and tool schema should shift behavior immediately.

@Hmbown Hmbown added this to the v0.8.56 milestone Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent execution blocks on long-running shell commands — sleep/background tasks should not stall the agent

2 participants