Stop committing the generated advisory index - #147
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the committed generated advisory index while retaining per-record advisories and local generation support.
Changes:
- Stops staging the generated index in the regeneration workflow.
- Ignores the generated index locally.
- Updates documentation and workflow expectations.
A critical issue remains: the workflow鈥檚 summary step still reads the deleted index and will fail during regeneration.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Summary |
|---|---|
spec/workflows_spec.rb |
Updates workflow expectations. |
lib/advisory_index.rb |
Clarifies local versus production index usage. |
CONTRIBUTING.md |
Documents the production advisory index. |
.gitignore |
Ignores the generated index. |
.github/workflows/regenerate.yml |
Stops staging the index, but its summary step still depends on it. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The index is built from the reviewed records on main and served by formulae.brew.sh at /api/advisories.json, where brew's advisory client reads it as of 6.0.19. Regenerate no longer concatenates or commits data/advisories.json, and the PR summary builds its before/after indexes in memory from the per-record trees instead of reading the committed copy. The advisories:concat rake task remains for local validation. Signed-off-by: Patrick Linnane <patrick@linnane.io>
p-linnane
force-pushed
the
drop-committed-advisory-index
branch
from
August 24, 2026 15:18
ad317be to
a6ec2b8
Compare
andrew
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The advisory index is built from the reviewed records on main and served at formulae.brew.sh/api/advisories.json, and brew's advisory client reads it there as of 6.0.19 (today's consumer is generate-formula-api), so the committed copy can go. The regeneration PR summary now builds its before/after indexes in memory from the per-record trees, and the advisories:concat rake task remains for local validation.