feat: Broad-Side lens batches poll concurrently (#136) - #149
Open
TheAmericanMaker wants to merge 1 commit into
Open
feat: Broad-Side lens batches poll concurrently (#136)#149TheAmericanMaker wants to merge 1 commit into
TheAmericanMaker wants to merge 1 commit into
Conversation
Collect previously polled one lens at a time to completion, so the slowest lens serialized the wall clock for lenses that had already finished server-side. In-flight batches now poll in parallel against one shared deadline via the new pollBatchesConcurrently helper, with per-lens progress callbacks; results still save in deterministic lens order and state updates stay per-lens. The poll interval is now injectable (pollIntervalMs) — a test seam the new regression tests use: a peak-concurrency probe proves both batches are in flight simultaneously without any timing flakiness. 2 new tests; 37 broadside tests, 397 total, all passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collect previously polled one lens at a time to completion, so the slowest lens serialized the wall clock for lenses that had already finished server-side. In-flight batches now poll in parallel against one shared deadline, with per-lens progress callbacks; results still save in deterministic lens order and state updates stay per-lens.
pollBatchesConcurrentlyhelper incore/broadside.tspollIntervalMsis now injectable onpollBatchUntilTerminal— a test seam37 broadside tests, 397 total, all passing.
Closes #136.