feat: Broad-Side per-language lens prompts (#137) - #150
Open
TheAmericanMaker wants to merge 1 commit into
Open
Conversation
The defect and conventions lenses hardcoded Go idioms; a Python scanner was told to look for 'goroutines without ctx'. Language profiles (Go, Python, Rust, TypeScript/JavaScript, plus a neutral default) now drive the defect pattern list and convention vocabulary per detected language, and convention prompts name language-appropriate idiom hints (dunder methods, error wrapping with %w, Result handling with ?). Language detection gains a .js bucket so JavaScript repos resolve to the TypeScript profile; unknown languages fall back to the neutral default. JSON schemas are unchanged, so synthesis is unaffected. Also corrects the changelog/roadmap attribution: the Broad-Side PR is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect and conventions lens prompts hardcoded Go idioms — a Python scanner was told to look for 'goroutines without ctx'. Language profiles (Go, Python, Rust, TypeScript/JavaScript, plus a neutral default) now drive the defect pattern list and convention vocabulary per detected language, and convention prompts name language-appropriate idiom hints.
Language detection gains a
.jsbucket so JavaScript repos resolve to the TypeScript profile. JSON schemas are unchanged, so synthesis is unaffected.Also corrects the Broad-Side attribution in changelog/roadmap: the PR is #144, not the unrelated issue #103.
Closes #137. Note: this branch inserts a bullet at the top of the CHANGELOG 'Added' section; #149 (concurrent polling) does the same. Please merge whichever lands first, and a trivial list-merge conflict on the second is expected — keep both bullets in order.