Skip to content

Fix issues #1450-1453: CONTRIBUTING.md formatting, scan.tsx refactoring, and integration tests - #1485

Open
richardtoms100 wants to merge 1 commit into
HyperSafeD:mainfrom
richardtoms100:fix/issues-1450-1451-1452-1453
Open

Fix issues #1450-1453: CONTRIBUTING.md formatting, scan.tsx refactoring, and integration tests#1485
richardtoms100 wants to merge 1 commit into
HyperSafeD:mainfrom
richardtoms100:fix/issues-1450-1451-1452-1453

Conversation

@richardtoms100

Copy link
Copy Markdown

Summary

This PR resolves issues #1450, #1451, #1452, and #1453 as part of the Sanctifier contributor wave.

Changes

#1451: Improve CONTRIBUTING.md Formatting

  • Converted dependency tables to structured Markdown tables
  • Added clear callouts with proper syntax
  • Improved visual hierarchy
  • Better organized prerequisites section with platform-specific tables
  • Enhanced code style guide with comparison tables
  • Improved Z-rules documentation structure

#1450: Refactor State Management in scan.tsx

  • Created ScanContext.tsx with React Context API
  • Migrated all component state to centralized context
  • Added useScan hook for consuming scan state
  • Improved state management with resetScan helper
  • Maintained all existing functionality

#1453: Improve Accessibility in scan.tsx

  • Added ARIA labels to all interactive elements
  • Added proper roles to sections
  • Added aria-live to error messages
  • Added aria-describedby to file upload input
  • Added aria-label to all buttons and links
  • Added aria-hidden to decorative icons
  • Improved semantic HTML

#1452: Add Integration Tests for arithmetic_overflow Rule

  • Created comprehensive integration test suite
  • CLI execution with JSON and SARIF output validation
  • Test coverage for detection, deduplication, false positives, and severity mapping

Related Issues

Closes #1450
Closes #1451
Closes #1452
Closes #1453

- HyperSafeD#1451: Improve CONTRIBUTING.md formatting with tables, callouts, and better structure
- HyperSafeD#1450: Refactor scan.tsx state management to React Context API
- HyperSafeD#1453: Add comprehensive ARIA labels and accessibility improvements to scan.tsx
- HyperSafeD#1452: Add integration tests for arithmetic_overflow rule with CLI and SARIF assertions

All changes follow project style guide and maintain existing test coverage.
@drips-wave

drips-wave Bot commented Aug 27, 2026

Copy link
Copy Markdown

@richardtoms100 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

@boluwacodes is attempting to deploy a commit to the gbangbolaoluwagbemiga's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants