feat: Resolve issues #1438-1440 - Installation docs and storage refactoring - #1492
Merged
Gbangbolaoluwagbemiga merged 2 commits intoAug 27, 2026
Conversation
- HyperSafeD#1438: Update installation instructions in README.md * Reorganized installation section with clear Quick Install * Added comprehensive table of alternative methods * Enhanced pre-built binaries section with SHA256 verification * Added detailed system requirements by platform * Included troubleshooting section for common install issues * Added update and verification procedures - HyperSafeD#1440: Refactor storage keys in vulnerable-contract * Replace string-based storage keys with contracttype enum * Add StorageKey enum with Admin, Balance, and Config variants * Prevents key collisions through type-safe access * Add get_admin and init_admin functions for better patterns * Add tests for storage key uniqueness and double-init prevention * Improve fail handling with Result return type example Notes: - Issue HyperSafeD#1439 is duplicate of HyperSafeD#1467 (already fixed in PR HyperSafeD#1488) - Issue HyperSafeD#1441 requires Dashboard.tsx which doesn't exist yet
|
@prodbycorne Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@boluwacodes is attempting to deploy a commit to the gbangbolaoluwagbemiga's projects Team on Vercel. A member of the Team first needs to authorize it. |
Gbangbolaoluwagbemiga
merged commit Aug 27, 2026
bbdabf1
into
HyperSafeD:main
35 of 49 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1438: Update Installation Instructions in README.md
Completely reorganized and enhanced the installation section:
New Structure:
Added Troubleshooting:
Benefits:
#1440: Refactor Storage Keys in Vulnerable Contract
Replaced string-based storage keys with type-safe contracttype enum:
Before:
After:
Additional Improvements:
Notes
contracts/reentrancy-guard/src/lib.rs#1439 is a duplicate of Add fuzz testing harness forcontracts/reentrancy-guard/src/lib.rs[Performance] #1467, which was already resolved in PR feat: Resolve issues #1465-1470 - Performance optimizations and testing #1488 (fuzz testing for reentrancy guard)frontend/components/Dashboard.tsx[Security] #1441 (Dashboard.tsx refactoring) requires a file that doesn't exist in the current codebase - marked for future implementationTesting
All existing tests pass. New tests added:
Related Issues
Closes #1438
Closes #1440
Closes #1439
Closes #1441