feat: improve behavior of http redirects - #201
Draft
padamstx wants to merge 1 commit into
Draft
Conversation
padamstx
force-pushed
the
redirect-headers
branch
from
November 17, 2023 20:18
2690483 to
17f802f
Compare
pyrooka
approved these changes
Nov 20, 2023
padamstx
marked this pull request as draft
November 20, 2023 19:42
Contributor
Author
|
Converted this PR to "draft" so that we do not merge it until we have the necessary CISO approvals. |
padamstx
force-pushed
the
redirect-headers
branch
from
November 21, 2023 22:00
17f802f to
3c67ebd
Compare
This commit modifies the Go core so that it will include "safe" headers when performing a cross-site redirect where both the original and redirected hosts are within IBM's "cloud.ibm.com" domain. Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
padamstx
force-pushed
the
redirect-headers
branch
from
November 27, 2023 19:13
3c67ebd to
6368be6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit modifies the Go core so that it will
include "safe" headers when performing a
cross-site redirect where both the original
and redirected hosts are within IBM's
"cloud.ibm.com" domain.