Skip to content

Add all accepted ILIAS 12 composer dependency PRs into composer.json#11255

Open
lscharmer wants to merge 1 commit into
ILIAS-eLearning:trunkfrom
lscharmer:12/composer-dependency-merge
Open

Add all accepted ILIAS 12 composer dependency PRs into composer.json#11255
lscharmer wants to merge 1 commit into
ILIAS-eLearning:trunkfrom
lscharmer:12/composer-dependency-merge

Conversation

@lscharmer
Copy link
Copy Markdown
Contributor

@lscharmer lscharmer commented Mar 11, 2026

Hi,
this PR merges all accepted ILIAS 12 composer dependencies.

The following PRs are included:

Missing dependency for ILIAS to work

None. All are included now.

Other changes

JSONLint

As the library JSONLint has not been suggested / accepted, I replaced the library with calls to json_decode.

The library was used to provide better error messages than json_decode if the config.json is not valid JSON.

@thibsy is this change fine for you?

PHPMailer

The PR #10574 suggests version 7.0 but this is incompatible with simplesaml's required version of the phpmailer so in agreement with @mjansen I changed this to version 6.8.

LTI Patch

As the file ./vendor/composer/patches/lti.patch doesn't exist anymore, I removed the patch from the composer.json.

Unit Tests

All Unit Tests which broke because of the version change of PHPUnit from v11 to v13 have been fixed.

Summary

In comparison to ILIAS 11:

New dependency:

Removed dependency:

@lscharmer lscharmer requested a review from thibsy March 11, 2026 15:00
@lscharmer lscharmer added technical board dependencies Pull requests that update a dependency file labels Mar 11, 2026
Copy link
Copy Markdown
Contributor

@thibsy thibsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lscharmer,

Thx a lot for providing the integration of the dependency PR's and for your detailed summary. Much appreciated.

  • jsonlint: thx for bringing this to my attention. I think this package was used to added user-friendliness for system administrators who write config files for the setup and potentially make mistakes =). I will check with @chfsx if we want to keep this or not.
  • phpunit: it's correct that we use this for the component bootstrap mechanism (at the moment). I will check in with @chfsx as well to discuss if we manage to replace this usage or have to request it for 12 as a prod dependency (again) ourselves.

Kind regards,
@thibsy

@lscharmer
Copy link
Copy Markdown
Contributor Author

PHP CS Fixer (PR #11408) is now integrated.

For transparency: The version for symfony/console had to be changed from v6.4.23 to v6.4.24 in order to be able to integrate friendsofphp/php-cs-fixer.

@lscharmer lscharmer force-pushed the 12/composer-dependency-merge branch 2 times, most recently from af2ebff to bd02bf2 Compare April 23, 2026 13:06
@lscharmer
Copy link
Copy Markdown
Contributor Author

lscharmer commented Apr 23, 2026

PHPUnit (PR #11423) is now integrated. I fixed all Unit Tests which broke because of the version change from v11 to v13.

Because of a security advisory, I also updated the following packages:

  • firebase/php-jwt 6.11.1 -> 7.0.5 because of: GHSA-2x45-7fc3-mxwq
    @sergiosant02 as this this is a major version change from 6.*.* to 7.*.* I hope this is still fine.
  • celtic/lti 5.2.0 -> 5.3.2 because it requires firebase/php-jwt < 7.0.0 (which is affected)
  • league/commonmark 2.7.0 -> 2.8.2 because of: GHSA-hh8v-hgvp-g3f5

And because of a version conflicts I updated:

  • symfony/console v6.4.23 -> v6.4.24

@rfalkenstein
Copy link
Copy Markdown
Contributor

quick notice @lscharmer : monolog was just confirmed: #11547
hope that helps :-)

@lscharmer lscharmer force-pushed the 12/composer-dependency-merge branch 2 times, most recently from 716b550 to f7ab2b1 Compare May 19, 2026 12:48
@lscharmer lscharmer force-pushed the 12/composer-dependency-merge branch from f7ab2b1 to 079a665 Compare May 19, 2026 12:54
@lscharmer
Copy link
Copy Markdown
Contributor Author

quick notice @lscharmer : monolog was just confirmed: #11547 hope that helps :-)

Hi @rfalkenstein,

Monolog & Bacon QR Code are now included as well :)

@lscharmer
Copy link
Copy Markdown
Contributor Author

Hi @ILIAS-eLearning/technical-board,
this PR is IMO now ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file technical board

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants