Add VertexDataGraph and EdgeDataGraph#121
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 59.89% 66.46% +6.57%
==========================================
Files 10 13 +3
Lines 566 841 +275
==========================================
+ Hits 339 559 +220
- Misses 227 282 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtfishman
reviewed
May 16, 2026
mtfishman
reviewed
May 18, 2026
mtfishman
reviewed
May 18, 2026
mtfishman
reviewed
May 18, 2026
mtfishman
reviewed
May 18, 2026
mtfishman
reviewed
May 18, 2026
mtfishman
reviewed
May 18, 2026
mtfishman
reviewed
May 18, 2026
…hrow(); end; ...`
…eturn similar types.
mtfishman
reviewed
May 18, 2026
mtfishman
reviewed
May 19, 2026
mtfishman
reviewed
May 19, 2026
mtfishman
reviewed
May 19, 2026
Member
|
FYI something you can do to temporarily get the tests passing in this PR is to add a |
07854cc to
71fbb01
Compare
d1089dd to
b91cd71
Compare
mtfishman
reviewed
May 27, 2026
…AbstractVertexDataGraph`
mtfishman
reviewed
May 28, 2026
mtfishman
reviewed
May 28, 2026
mtfishman
reviewed
May 28, 2026
A generic version now exists in `NamedGraphs.GraphsExtensions`
Removed NamedGraphs source dependency from Project.toml.
Removed NamedGraphs source dependency from Project.toml
VertexDataGraph and EdgeDataGraph as concrete subtypes of AbstractVertexOrEdgeDataGraphVertexDataGraph and EdgeDataGraph
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This point of this abstract interface is to allow the partial implementation of the
Dictionaries.jlinterface, on these graph types.VertexDataGraphandEdgeDataGraphas concrete subtypes ofAbstractVertexDataGraphandAbstractEdgeDataGraphrespectively.insert_vertex_datathat should be overloaded if a givenAbstractVertexDataGraphgraphisinsertable. Like wiseinsert_edge_dataforAbstractEdgeDataGraph.similar_graph(::AbstractGraph, ::Type, ::Type), andsimilar_graph(::AbstractGraph, ::Type, ::Type, vertices)have been removed.A subtype of
AbstractVertexDataGraphorAbstractEdgeDataGraphimplements a stricter indexing interface, inline with the one used byDictionaries.jl, that issetindex!strictly sets existing indices (doesn't add a vertex/edge that isn't already in the graph). One should useinsert!to strictly add a new vertex/edge with data, andset!to perform anupsert(previous behavior ofsetindex!.Eventually, this interface will be applied to
AbstractDataGraph, but to avoid breaking changes this is deferred until a later date.New Interface
For a settable and insertable vertex data graph, one must define:
An edge data graph only needs: