Skip to content

fix issues with tide configure --auto causing blank initial prompts #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaysond wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix issues with tide configure --auto causing blank initial prompts #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09845bf
fix issues with tide configure --auto causing blank initial prompts
kaysond Jul 21, 2026
6d7e848
fix set_color calls leaving trailing escape codes in tide configure -…
kaysond Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions functions/_tide_sub_configure.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,14 +56,14 @@ function _tide_title -a text
set -g _tide_configure_first_option_after_title
end

function _tide_option -a symbol text
function _tide_option -a symbol text color
set -ga _tide_symbol_list $symbol
set -ga _tide_option_list $text

if not set -q _flag_auto
set -g _tide_configure_first_prompt_after_option

set_color -o
set_color -o $color
set -e _tide_configure_first_option_after_title || echo
echo "($symbol) $text"
set_color normal
Expand Down
1 change: 1 addition & 0 deletions functions/fish_prompt.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ source (functions --details _tide_pwd)

set -l prompt_var _tide_prompt_$fish_pid
set -U $prompt_var # Set var here so if we erase $prompt_var, bg job won't set a uvar
set -e _tide_repaint # Clear any repaint flag triggered by the set -U above

set_color normal | read -l color_normal
status fish-path | read -l fish_path
Expand Down
16 changes: 8 additions & 8 deletions functions/tide/configure/choices/all/finish.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
function finish
_tide_title Finish

echo
set_color red
_tide_option y 'Overwrite your current tide config'
set_color normal
echo
set -q _flag_auto || echo
_tide_option y 'Overwrite your current tide config' red
set -q _flag_auto || echo

_tide_option p 'Exit and print the config you just generated'
echo
set -q _flag_auto || echo

_tide_menu (status function)
switch $_tide_selected_option
case 'Overwrite your current tide config'
_tide_finish
command -q clear && clear
set -q _flag_auto || _tide_print_configure_current_options
set -q _flag_auto || begin
command -q clear && clear
_tide_print_configure_current_options
end
case 'Exit and print the config you just generated'
_tide_exit_configure
command -q clear && clear
Expand Down
Loading